On Thu, Jan 17, 2013 at 09:35:22PM +0200, Alon Levy wrote:
Adds a qxl-ram attribute globaly to the video.model element, that changes the resulting qemu command line only if video.type == "qxl".
That attribute gets a default value of 64*1024 only if model.type is "qxl". In effect not changing any xml or argv for non qxl devices.
For qxl devices a new property is set: -global qxl-vga.ram_size=<ram>*1024 or -global qxl.ram_size=<ram>*1024
For the main and secondary qxl devices respectively.
The default for the qxl ram bar is the same as the default for the qxl vram bar, 64*1024. --- I've added a qxl-ram attribute. There is no precedent for adding am attribute prefixed like this, so I'm open for any other suggestion on how to do it.
What is the difference between this new RAM size and what we currently set for ram size. That will influence how we pick a good name, ie one with any qxl prefix, which is not something we can use.
Just to be clear: ram_size determines the size of the first bar of the qxl device, until now unsettable via libvirt. This bar is used for: surface 0 (and VGA emulation), rendering commands, monitors config, ram header. vram_size determines the size of the second bar of the qxl device. settable via the vram attribute. This bar is used for: surface > 0 allocations (aka off screen surfaces).
Daniel -- |: http://berrange.com -o- | http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- | http://virt-manager.org :| |: http://autobuild.org -o- | http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- | http://live.gnome.org/gtk-vnc :|