15 Sep
2019
15 Sep
'19
11:51 p.m.
On 9/13/19 4:02 PM, Michal Prívozník wrote:
On 9/13/19 4:52 PM, Laine Stump wrote:
+ qemuCaps && !virQEMUCapsGet(qemuCaps, QEMU_CAPS_VHOSTUSER_MULTIQUEUE)) {
NULL is never passed to qemuCaps, so no need to check it.
I had put that in so I could also call it from qemuDomainDeviceDefValidateNetwork() (which doesn't have qemuCaps or even a domainObjPtr to get it from) and catch as many invalid configs as possible at parse time rather than runtime. But I wasn't happy with the patch to do that so I haven't sent it (and anyway it looks like I can just add qemuCaps to the args for that function), so I'll take it out before pushing.