Re: [libvirt] [PATCH 0/5] enforce and simplify qga interactions

On 19.09.2016 12:47, Michal Privoznik wrote: > On 16.09.2016 12:35, Nikolay Shirokovskiy wrote: >> First 2 patches fix bugs of libvirt - qga communication. >> They deal with the channel pecularities described in >> http://wiki.qemu.org/Features/QAPI/GuestAgent. First >> patch address https://bugzilla.redhat.com/show_bug.cgi?id=1090551 >> bug. >> >> Next 3 patches hide details of channel pecularities from client, >> so there is no more need to reissue commands for the reasons other >> then simple timeout. >> >> Nikolay Shirokovskiy (5): >> qemu: agent: ignore delayed reply when unsynced >> qemu: agent: ignore garbage while waiting for sync reply >> qemu: agent: skip outdated sync replies >> qemu: agent: reissue sync on garbage sync reply >> qemu: agent: give better error messages whe agent monitor is down >> >> src/qemu/qemu_agent.c | 91 ++++++++++++++++++++++++++++++--------------------- >> 1 file changed, 54 insertions(+), 37 deletions(-) >> > > The patches look good to me, but they might be considered controversial, > so I'll wait couple of hours before merging them. > > ACK meanwhile. > I've pushed this now. Michal