Re: [libvirt] [PATCH] qemu/kvm: allow to hotadd scsi/virtio disks

On Fri, Oct 17, 2008 at 11:05:50AM +0100, Daniel P. Berrange wrote: > On Fri, Oct 17, 2008 at 09:48:58AM +0200, Guido G?nther wrote: > > Hi, > > recent kvm allows to hot add scsi/virtio disks, it uses pci hotplugging > > for that. Attached patch adds support for this to libvirt. > > Great, I didn't know SCSI allowed hotplug in QEMU. Even NICs are hot pluggable now. And since qemu prints a reasonable OK message we can parse the PCI slot number from the reply which allows for unplugging as well (delayed that since I'm a bit short on time). My patch contained a tiny error: -+ safe_path = qemudEscapeShellArg(dev->data.disk->src); ++ safe_path = qemudEscapeMonitorArg(dev->data.disk->src); corrected version attached,