Re: [libvirt] [PATCH 08/13] qemu: add support for libiscsi

On Mon, Feb 25, 2013 at 06:44:27PM +0100, Paolo Bonzini wrote: > libiscsi provides a userspace iSCSI initiator. > > The main advantage over the kernel initiator is that it is very > easy to provide different initiator names for VMs on the same host. > Thus libiscsi supports usage of persistent reservations in the VM, > which otherwise would only be possible with NPIV. > > libiscsi uses "iscsi" as the scheme, not "iscsi+tcp". We can change > this in the tests (while remaining backwards-compatible manner, because > QEMU uses TCP as the default transport for both Gluster and NBD). > > Signed-off-by: Paolo Bonzini <pbonzini(a)redhat.com&gt; > --- > src/qemu/qemu_command.c | 49 +++++++++++++++++++++- > tests/qemuargv2xmltest.c | 1 + > .../qemuxml2argv-disk-drive-network-gluster.args | 2 +- > .../qemuxml2argv-disk-drive-network-iscsi.args | 1 + > ...ml2argv-disk-drive-network-nbd-ipv6-export.args | 2 +- > .../qemuxml2argv-disk-drive-network-nbd-ipv6.args | 2 +- > tests/qemuxml2argvtest.c | 2 + > 7 files changed, 54 insertions(+), 5 deletions(-) > create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-iscsi.args ACK