On 03/15/2011 04:45 PM, Eric Blake wrote:
On 03/15/2011 02:32 PM, Laine Stump wrote:
In the subject, s/if //
A bug in libnl (see https://bugzilla.redhat.com/show_bug.cgi?id=677724 and https://bugzilla.redhat.com/show_bug.cgi?id=677725) makes it very easy to create a failure to connect to the netlink socket when trying to open a macvtap network device ("type='direct'" in domain interface XML). When that error occurred, there was no log message, leading virsh (for example) to report "unknown error".
This patch logs a message which will hopefully be more useful. (All other error exits from the same function were already logging a message). Well, not all of them - nl_handle_alloc failure was silent instead of calling virReportOOMError before returning -1. Likewise for the final nl_recv not calling virReportSystemError.
Ah right, I see what you mean. I hadn't looked as closely, just at the "goto err_exit" places. I'll do a V2 later tonight. Right now the front door is opening...