On 06/21/2011 06:05 PM, Stefan Berger wrote:
In a second cleanup step this patch makes several interface functions from macvtap.c commonly available by moving them into interface.c and prefixing their names with 'iface'.
--- src/libvirt_private.syms | 8 src/util/interface.c | 609 +++++++++++++++++++++++++++++++++++++++++++++++ src/util/interface.h | 37 ++ src/util/macvtap.c | 495 -------------------------------------- 4 files changed, 663 insertions(+), 486 deletions(-)
Unfortunately, this breaks things when compiling on RHEL 5. There, macvtap.c was not compiled, but interface.c is compiled, and I'm now getting errors like this: util/interface.c: In function 'ifaceMacvtapLinkAdd': util/interface.c:538: warning: assignment makes pointer from integer without a cast util/interface.c:557: error: 'IFLA_LINKINJFO' undeclared (first use in this function) ... We need some preprocessor conditionals to filter out these functions when support is lacking. -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org