On 10/27/2014 06:54 PM, Tony Krowiak wrote:

On 10/26/2014 12:12 PM, Laine Stump wrote:

Note that I've attached a patch that addresses all the issues I raise in
this review. Please try it out; if you approve, I will squash it in and
push the result (with my name added as Signed-Off-By:, so that you don't
have to take all the blame if I screwed something up :-))

Oh, and so that it is officially said: ACK, with my small patch squashed in.

I applied your patches and tested them. All is working as before applying it.

ACK this patch to my patch.

Thanks for the contribution!

I made a couple other minor changes to spacing, braces, and checking for return value < 0 (rather than non-0), and pushed the result.