Re: [libvirt] [PATCH] qemu: don't refuse to undefine a guest with NVRAM file
On Tue, Feb 24, 2015 at 05:46:12PM +0100, Kashyap Chamarthy wrote:
On Tue, Feb 24, 2015 at 10:12:20AM +0000, Daniel P. Berrange wrote:
[. . .]
Edit the Fedora 21 libvirt guest. Guest XML here[*]:
$ virsh edit devstack
[. . .]
Try to add the below fragment under 'os' element:
<loader readonly='yes'
type='pflash'>/usr/share/AAVMF/AAVMF_CODE.fd</loader>
<nvram>/var/lib/libvirt/nvram/fedora-21-aarch64-nvram</nvram>
It fails to validate the XML:
error: XML document failed to validate against schema: Unable to validate doc against
/usr/share/libvirt/schemas/domain.rng
Extra element devices in interleave
Element domain failed to validate content
Failed. Try again? [y,n,i,f,?]:
I ignored the validation here 'i' (thanks Michal Privoznik for the
suggestion on IRC -- this looks like something to do with some XML
validation work from Martin Kletzander), and went ahead to test the
actual bug this patch fixes:
It works:
A guest w/ 'nvmram' XML element as below:
$ virsh dumpxml node2 | grep -i nvram -A2 -B3
<os>
<type arch='aarch64' machine='virt'>hvm</type>
<loader readonly='yes'
type='pflash'>/usr/share/AAVMF/AAVMF_CODE.fd</loader>
<nvram>/var/lib/libvirt/nvram/fedora-21-aarch64-nvram</nvram>
<boot dev='hd'/>
</os>
Can be undefined successfully.
--
/kashyap