Re: [libvirt] [PATCH v3 0/2] Adding locale support for virStrToDouble().
On Thu, Jun 22, 2017 at 11:30:06 +0200, Martin Kletzander wrote:
On Wed, Jun 21, 2017 at 02:08:27PM -0300, Julio Faracco wrote:
> The commits add locale support for virStrToDouble() due to differences between
> the mantissa separator in different languages. For example, kernel always uses
> dot to separate mantissa. An user who is using pt_BR locale (for example) uses
> comma as a separator. So, this user will have problems to parse a kernel
> settings using strtod() function.
>
> One of commits move the virDoubleToStr() to virstring.* to share locale
> global variables. Joining the two functions makes more sense.
>
Reviewed-by: Martin Kletzander <mkletzan(a)redhat.com>
I'll push it in a minute. Thanks for the patches and patience!
Since this broke build and will require fixing. I'd prefer that the
code to set and revert the locale will be wrapped into a function rather
than scattering conditionally compiled code through the code base.
Attachments:
- signature.asc (application/pgp-signature — 833 bytes)