Re: [PATCH v2] storage: Upgrade default qcow2 verion to 1.1
On Tue, Mar 12, 2024 at 10:36:28AM +0100, Peter Krempa wrote:
On Wed, Mar 06, 2024 at 01:20:13 +0530, Abhiram Tilak wrote:
> Change the default to modern qcow2 as it's supported by all qemu
> versions supported by libvirt and in fact 'qemu-img' already defaults to
> the new format for a long time.
>
> Some Unittests require changes to pass, now that version 1.1 is default.
> Unittests like `qcow2-1.1.argv` may not be relevant anymore, but this patch
> doesn't affect them.
I've added a:
Closes: https://gitlab.com/libvirt/libvirt/-/issues/602
>
> Signed-off-by: Abhiram Tilak <atp.exp(a)gmail.com>
> Reviewed-by: Peter Krempa <pkrempa(a)redhat.com>
> ---
And pushed the patch; thanks for fixing this.
...but this is a behavioural change of our API. Images created by
applications will now have reduced portability across platforms,
since v3 is supported by a subset of platforms that support v2,
which I would call a regression.
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|