Re: [libvirt] [PATCHv4 03/15] Switch from yajl to Jansson

On 07/18/2018 10:44 AM, Ján Tomko wrote: > Yajl has not seen much activity upstream recently. > Switch to using Jansson >= 2.5. > > All the platforms we target on https://libvirt.org/platforms.html > have a version >= 2.7 listed on the sites below: > https://repology.org/metapackage/jansson/versions > https://build.opensuse.org/package/show/devel:libraries:c_c++/libjansson > > Additionally, Ubuntu 14.04 on Travis-CI has 2.5. Set the requirement > to 2.5 since we don't use anything from newer versions. > > Implement virJSONValue{From,To}String using Jansson, delete the yajl > code (and the related virJSONParser structure) and report an error > if someone explicitly specifies --with-yajl. > > Also adjust the test data to account for Jansson's different whitespace > usage for empty arrays and tune up the specfile to keep 'make rpm' > working when bisecting. > > Signed-off-by: Ján Tomko <jtomko(a)redhat.com&gt; > --- > src/util/virjson.c | 211 +++++++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 211 insertions(+) > Too late now, but git bisect and running the test suite seems to be broken starting with this patch as I started getting "FAIL: qemublocktest" here running a bisect chasing something else. As I found out "later" I didn't have jansson-devel dnf installed either, so that may have affected my results. Who knows at this point. The failure goes away with patch 13, but that introduced other issues for me. I'll respond there with what I found.