Re: [libvirt] [PATCHv3 2/4] Introduce filesystem limits to virDomainFSDef
On Wed, May 23, 2012 at 01:53:53PM -0600, Eric Blake wrote:
On 05/23/2012 09:10 AM, Guido Günther wrote:
> ---
> docs/formatdomain.html.in | 14 ++++++++++++++
> docs/schemas/domaincommon.rng | 12 ++++++++++++
> src/conf/domain_conf.c | 30 +++++++++++++++++++++++++++---
> src/conf/domain_conf.h | 2 ++
> 4 files changed, 55 insertions(+), 3 deletions(-)
>
> @@ -11319,6 +11335,14 @@ virDomainFSDefFormat(virBufferPtr buf,
> if (virDomainDeviceInfoFormat(buf, &def->info, flags) < 0)
> return -1;
>
> +
> + if (def->space_hard_limit)
> + virBufferAsprintf(buf, " <space_hard_limit
unit='B'>"
Your cover letter said you switched this to 'bytes'; what happened? Oh,
I see - the first hunk of 3/4 fixed that - in other words, you just
rebased the fix onto the wrong patch.
I was sure I moved this around already but it seems I didn't. Thanks for
spotting! Pushed the whole series now with your suggested
modifications.
Cheers,
-- Guido
Also, your patches were not marked in-reply-to: your cover letter, so I
ended up receiving two threads from you. You might want to investigate
why your git settings aren't threading properly.
ACK with the hunk from 3/4 floated into this one.
--
Eric Blake eblake(a)redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org