Re: [libvirt] [PATCH v2] network: remove stale function
On Wed, 2019-01-09 at 21:47 -0500, Laine Stump wrote:
networkMigrateStateFiles was added nearly 5 years ago when the
network
state directory was moved from /var/lib/libvirt to /var/run/libvirt
just prior to libvirt-1.2.4). It was only required to maintain proper
state information for networks that were active during an upgrade that
didn't involve rebooting the host. At this point the likelyhood of
anyone upgrading their libvirt from pre-1.2.4 directly to 5.0.0 or
later *without rebooting the host* is probably so close to 0 that no
properly informed bookie would take *any* odds on it happening, so it
seems appropriate to remove this pointless code.
The rationale makes sense to me.
[...]
@@ -691,12 +604,6 @@ networkStateInitialize(bool privileged,
LOCALSTATEDIR "/lib/libvirt/radvd") < 0)
goto error;
Please remove this empty line as well.
- /* migration from old to new location is only applicable
for
- * privileged mode - unprivileged mode directories haven't
- * changed location.
- */
- if (networkMigrateStateFiles(network_driver) < 0)
- goto error;
With the above addressed,
Reviewed-by: Andrea Bolognani <abologna(a)redhat.com>
Maybe wait until 5.0.0 is released before pushing, in order to give
other people a chance to voice any concerns they might have.
--
Andrea Bolognani / Red Hat / Virtualization