Re: [libvirt] [PATCH v2] Fix blkdeviotune for shutoff domain
On 05/24/2013 01:14 PM, Jiri Denemark wrote:
On Fri, May 24, 2013 at 11:57:32 +0200, Martin Kletzander wrote:
> Function qemuDomainSetBlockIoTune() was checking QEMU capabilities
> even when !(flags & VIR_DOMAIN_AFFECT_LIVE) and the domain was
> shutoff, resulting in the following problem:
>
> virsh # domstate asdf; blkdeviotune asdf vda --write-bytes-sec 100
> shut off
>
> error: Unable to change block I/O throttle
> error: unsupported configuration: block I/O throttling not supported with this QEMU
binary
>
> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=965016
>
> Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com>
> ---
>
> Notes:
> Moved the job starting before anything happens
>
> src/qemu/qemu_driver.c | 33 ++++++++++++++-------------------
> 1 file changed, 14 insertions(+), 19 deletions(-)
ACK
Jirka
Thanks, pushed.
Martin