Re: [libvirt] [PATCH v2] qemu: avoid slash characters to the new domain name.

[Please don't top-post on technical lists.] On Mon, Apr 23, 2018 at 11:06:32 -0300, Julio Faracco wrote:

Hi Jan,

I totally agree. Using only virDomainDefPostParseCheckFeatures() is so better than the full virDomainDefPostParse() (as you mention too). But it is an internal function which is not available outside (for some reason).

Well ... for the reason that it should not be used. Just do the check here without any other checks. The only thing that is changed in this API is the name. I originally only objected to do the check in the virDomainRename function. Doing it in qemuDomain rename is okay.

Julio Cesar Faracco

2018-04-23 4:51 GMT-03:00 Ján Tomko <jtomko@redhat.com>:

...

On Mon, Apr 23, 2018 at 12:27:40AM -0300, Julio Faracco wrote:

[...]