8 Feb
2013
8 Feb
'13
5:27 p.m.
On Mon, Feb 04, 2013 at 10:45:22AM +0100, Natanael Copa wrote:
This is a rework of the previous sent 'set public ip for nat' patches [1].
Changes v2: - Use separate attributes for addresses and ports as suggested by Laine. - support set port range without setting public ip
Broadly looks good to me. If you get rid of patch 2 which is just a special case of patch 3, then I'd ack 3 + 4. Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|