On 12/16/2015 03:11 AM, Ian Campbell wrote:
On Wed, 2015-12-16 at 09:45 +0000, Ian Campbell wrote:
On Tue, 2015-12-15 at 14:32 -0700, Jim Fehlig wrote:
Hi All,
Ian Campbell recently attempted [1] to fix and issue around MAX_VIRT_VPUS on ARM that required adding a new XEND_CONFIG_VERSION. After some discussion [2] we decided to drop support for all of the old xend config versions and go with the version supported in Xen 4.0, since the xl syntax was originally based on (and intended to be compatible with) xm circa that point in time.
This series removes all traces of xend config version from the codebase, essentially removing support for Xen 3.x. Hopefully I succeeding in making the rather large series reviewable. The series is also available on the remove-xend-config-version branch of my libvirt github clone [2]. Wow, thanks for offering to take this over, I had no idea it would end up with so much yakk hair everywhere! I've looked through it and the transformations look good to me:
Acked-by: Ian Campbell <ian.campbell@citrix.com>
Thanks for taking the time to look at all of these changes!
There were a couple of references to xendConfigVersion remaining in comments on src/xen/xen_driver.c.
I'll remove "with xendConfigVersion >= 3" from those sentences in 13/16.
There was also po/* which I presume some sort of semiautomated update will strip eventually.
I think so. It is due to removal of translated error messages in src/xen/xend_internal.c.
I'm not sure what to make of the references under docs/api_extension/.
Those are old patches that serve as an example of implementing a new API in libvirt. AFAIK, no one expects those to be kept in sync with current code.
I tested this on ARM with "Xen: support maxvcpus in xm and xl config" on top and it worked.
Good to hear. Thanks for all the help! Regards, Jim