Re: [libvirt] [PATCH v2 08/23] qemu: monitor: Add algorithm for combining query-(hotpluggable-)-cpus data
On Tue, Aug 23, 2016 at 17:54:51 +0530, Shivaprasad G Bhat wrote:
On 08/19/2016 08:08 PM, Peter Krempa wrote:
[...]
> + /* match entries from query cpus to the output array taking
into account
> + * multi-vcpu objects */
> + for (j = 0; j < ncpuentries; j++) {
> + /* find the correct entry or beginning of group of entries */
> + for (i = 0; i < maxvcpus; i++) {
> + if (cpuentries[j].qom_path && vcpus[i].qom_path &&
> + STRPREFIX(cpuentries[j].qom_path, vcpus[i].qom_path))
Paths /machine/peripheral/vcpu10(and so on) would all end up matching
/machine/peripheral/vcpu1 (i =1)
and vcpu[10] onwards wont have a tid assigned and eventually fail at
qemuDomainValidateVcpuInfo() for vcpus beyond 10.
Good catch. I've fixed it in v3 and added a test case.
Peter