On 04/09/2013 04:35 PM, Peter Krempa wrote:
On 04/09/13 20:33, John Ferlan wrote:
I believe this set of patches should be applied instead of those from
https://www.redhat.com/archives/libvirt-cim/2013-April/msg00006.html
I suppose we could consider combining the two functions; however, there are a couple place where the return version string is compared more than once, so I kept both interfaces.
The vxml change is just an informative message that showed me the name of the image that was failing - I had created 'default-kvm-dimage.img' and tests were failing to find 'default-kvm-dimage' to place into the cimtest storage pool.
John Ferlan (2): vxml: Add which volume could not be found to error message Add and utilize virsh_version_cmp
For a next submission please use --subject-prefix="PATCH libvirt-cim" for git format-patch when sending patches to libvir-list to avoid confusion with core libvirt stuff.
You can also do: git config format.subjectprefix 'cim PATCH', so that you don't have to remember to use --subject-prefix on every 'git send-email' invocation. I kind of like the package before the PATCH, so that coupled with the list auto-addition of [libvirt], your mails would look like: [libvirt][cim PATCH 0/2] ... which is a bit shorter than: [libvirt][PATCH libvirt-cim 0/2] ... and still visually similar to [libvirt-cim] if the list didn't auto-munge the subject. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org