Re: [libvirt] [PATCH 05/15] qemu: Extract parsing of qemu namespace env vars into separate function

On Tue, Jun 18, 2019 at 03:10:14PM +0200, Peter Krempa wrote:

Simplify the main function by splitting out how we parse the extra passthrough environment variables.

Note that the validation function checks that the first letter must be a character or underscore which makes the check whether the name is redundant.

Signed-off-by: Peter Krempa <pkrempa@redhat.com> --- src/qemu/qemu_domain.c | 111 ++++++++++++++++++++++------------------- 1 file changed, 59 insertions(+), 52 deletions(-)

Reviewed-by: Ján Tomko <jtomko@redhat.com> Jano