Re: [Libvir] [PATCH] check file format in virsh attach/detach-device

On Thu, Aug 02, 2007 at 03:01:07PM +0900, Masayuki Sunou wrote:

Hi Daniel, Rich

Thanks for reviewing and suggestion.

I adopt (b) in consideration Daniel's suggestion. --> Error message exists already.

This patch fixes virParseXMLDevice() for attach-device and virDomainXMLDevID() for detach-device.

Looks fine to me, I applied it after just a couple of cosmetic changes. thanks a lot, it's in CVS ! Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard@redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/