Re: [libvirt] [PATCH 2/9] virNetDevBandwidthUpdateRate: turn class_id into integer
On 11.08.2015 02:49, John Ferlan wrote:
On 08/03/2015 02:39 AM, Michal Privoznik wrote:
> This is no functional change. It's just that later in the series we
> will need to pass class_id as an integer.
>
> Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com>
> ---
> src/network/bridge_driver.c | 4 ++--
> src/util/virnetdevbandwidth.c | 10 +++++++---
> src/util/virnetdevbandwidth.h | 2 +-
> 3 files changed, 10 insertions(+), 6 deletions(-)
>
something that dawned on me reading later patches...
> diff --git a/src/util/virnetdevbandwidth.c b/src/util/virnetdevbandwidth.c
> index 6ae0877..91201ae 100644
> --- a/src/util/virnetdevbandwidth.c
> +++ b/src/util/virnetdevbandwidth.c
> @@ -638,7 +638,8 @@ virNetDevBandwidthUnplug(const char *brname,
> /**
> * virNetDevBandwidthUpdateRate:
> * @ifname: interface name
> - * @classid: ID of class to update
> + * @id: unique identifier (MUST be greater than 2)
^^^ Comment says MUST be > 2, but there's no check/error... Also I note
"2" is passed often...
Yeah, this is basically my personal note. In fact, it's not valid at all
and I will remove it. The intent was that in the QoS tree that is
created on the bridge, class/leaf #2 has a specific purpose => all
nonguaranteed traffic goes through it. Therefore it should be updated
with higher caution than anything else. But this comment is just misleading.
Michal