Re: [libvirt] [PATCH] Clean some comments about locking

On 02/12/2013 04:17 PM, Daniel P. Berrange wrote: > On Tue, Feb 12, 2013 at 08:14:40AM -0700, Eric Blake wrote: >> On 02/12/2013 05:52 AM, Martin Kletzander wrote: >>> Since the BQDL has been broken, this patch tries to cleanup some >>> information about it in various comments. >>> --- >>> To be applied after Dan's patch [1] which removes unnecessary >>> qemuDriverLocks. >>> >>> @@ -1734,7 +1733,7 @@ qemuDomainSnapshotDiscardAllMetadata(virQEMUDriverPtr driver, >>> } >>> >>> /* >>> - * The caller must hold a lock on both driver and vm, and there must >>> + * The caller must hold a lock the vm and there must >> >> s/lock the/lock on the/ >> >> ACK, whether Dan squashes this in directly or you push as a followup. > > It really ought to be squashed into the main patch I think > Go ahead, I just didn't want to bother you with nit-picking on comments.