Re: [libvirt] [PATCH] virsh: Add a helper to parse cpulist

On 28/03/13 19:36, Osier Yang wrote: > vcpupin and emulatorpin use same code to parse the cpulist, this > abstracts the same code as a helper. Along with various code style > fixes, and error improvement (only error "Physical CPU %d doesn't > exist" if the specified CPU exceed the range, no "cpulist: Invalid > format", see the following for an example of the error prior to > this patch). > > % virsh vcpupin 4 0 0-8 > error: Physical CPU 4 doesn't exist. > error: cpulist: Invalid format. > --- > tools/virsh-domain.c | 278 > ++++++++++++++++++++------------------------------- > 1 file changed, 106 insertions(+), 172 deletions(-) > > diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c > index d1e6f9d..0fe2a51 100644 > --- a/tools/virsh-domain.c > +++ b/tools/virsh-domain.c > @@ -5460,6 +5460,97 @@ vshPrintPinInfo(unsigned char *cpumaps, size_t > cpumaplen, > return true; > } > +static unsigned char * > +virParseCPUList(vshControl *ctl, const char *cpulist, > + int maxcpu, size_t cpumaplen) > +{ > I meant vshParseCPUList. With the attached diff squashed in: -- libvir-list mailing list libvir-list(a)redhat.com https://www.redhat.com/mailman/listinfo/libvir-list