Re: [Libvir] PATCH: 1/16: public API

On Wed, Feb 20, 2008 at 04:00:39AM +0000, Daniel P. Berrange wrote: > On Tue, Feb 12, 2008 at 04:30:07AM +0000, Daniel P. Berrange wrote: > > This defines the public API for the storage pool and volume support. > > The naming of the APIs follows the example set by the network and > > domain APIs whereever the logical functions match. The main change > > since previous iterations is the addition of an explicit API for > > virStoragePoolBuild and virStoragePoolDelete, to allow formatting > > of the underlying storage, and permanent deletion. Many of the APIs > > also now have an 'unsigned int flags' param. It is also possible to > > lookup a volume directly based on its path or key without having the > > associated pool object ahead of time. > > > include/libvirt/libvirt.h | 195 +++++++++++++++++++++++++++++++++++++++++++ > include/libvirt/libvirt.h.in | 195 +++++++++++++++++++++++++++++++++++++++++++ > src/libvirt_sym.version | 45 +++++++++ > 3 files changed, 435 insertions(+) API looks fine to me, I guess all parts have been reviewed, at this point the best we can do is push it to CVS with the proposed changes, and start to get people to use it. If needed we can state that that the storage APIs are in beta in the next release(s) and will be consideered frozen in 0.5.0 within a couple of months. So let's push this !