[libvirt] [PATCH 7/8] qemu: Resolve Coverity FORWARD_NULL
Coverity complains over the [n]values pairing in virQEMUCapsFreeStringList
and rather than make a bunch if "if values" checks prior to calling, by
just adding the values check inside the free function we avoid the chance
that somehow nvalues is > 0, while values == NULL
Signed-off-by: John Ferlan <jferlan(a)redhat.com>
---
src/qemu/qemu_capabilities.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
index d50863f..25c15bf 100644
--- a/src/qemu/qemu_capabilities.c
+++ b/src/qemu/qemu_capabilities.c
@@ -1702,6 +1702,8 @@ virQEMUCapsFreeStringList(size_t len,
char **values)
{
size_t i;
+ if (!values)
+ return;
for (i = 0; i < len; i++)
VIR_FREE(values[i]);
VIR_FREE(values);
@@ -1794,7 +1796,7 @@ virQEMUCapsParseDeviceStrObjectProps(const char *str,
ret = nproplist;
cleanup:
- if (ret < 0 && proplist)
+ if (ret < 0)
virQEMUCapsFreeStringList(nproplist, proplist);
return ret;
}
--
2.1.0