On 01/17/2012 02:47 PM, Daniel P. Berrange wrote:
On Wed, Dec 07, 2011 at 07:08:00PM +0100, Peter Krempa wrote:
This series fixes anoying console corruption if two clients try to connect at same time to the console. The current state of this is, that two/more of threads compete for the data from the PTY. This causes that each of the consoles get scrambled and unusable.
These patches add mutual exclusion for opening consoles with two different approaches and a option to terminate existing console streams.
A sample implementation is done using qemu driver, but i'll add more of them if this will be OK. (They're basicaly the same as in qemu).
For convinience, to review these patches:
git checkout -b console_corruption 8d16201fe0e63afb5416a8eb7c6478f582ccccc0 git pull git://aeon.pipo.sk/libvirt.git console_dup
What is the status of these patches ? Do you have any v3 pending ?
I kind of stalled on my review; I'll finish that up, and hope to see a v3 soon. -- Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org