Re: [libvirt] [PATCH 19/23] Replace use of qemuReportError with virReportError

On 07/18/12 20:40, Daniel P. Berrange wrote: >From: "Daniel P. Berrange" <berrange(a)redhat.com&gt; > >Update the QEMU driver to use virReportError instead of >the qemuReportError custom macro > >Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com&gt; >--- > cfg.mk | 1 - > src/qemu/qemu_agent.c | 142 ++-- > src/qemu/qemu_capabilities.c | 16 +- > src/qemu/qemu_cgroup.c | 26 +- > src/qemu/qemu_command.c | 1066 ++++++++++++------------ > src/qemu/qemu_conf.c | 26 +- > src/qemu/qemu_conf.h | 4 - > src/qemu/qemu_domain.c | 94 +-- > src/qemu/qemu_driver.c | 1834 +++++++++++++++++++++--------------------- > src/qemu/qemu_hostdev.c | 59 +- > src/qemu/qemu_hotplug.c | 362 ++++----- > src/qemu/qemu_migration.c | 284 +++---- > src/qemu/qemu_monitor.c | 384 ++++----- > src/qemu/qemu_monitor_json.c | 546 ++++++------- > src/qemu/qemu_monitor_text.c | 532 ++++++------ > src/qemu/qemu_process.c | 216 ++--- > 16 files changed, 2795 insertions(+), 2797 deletions(-) > ACK, mechanic, but *HUGE*. While reviewing I found some places that would require polishing but are pre-existing. I'm attatching the patch for that. Peter

From 071801e62511cc9db451f18a87d1f0ab772687d3 Mon Sep 17 00:00:00 2001 Message-Id: <071801e62511cc9db451f18a87d1f0ab772687d3.1342695008.git.pkrempa(a)redhat.com&gt; From: Peter Krempa <pkrempa(a)redhat.com&gt; Date: Thu, 19 Jul 2012 12:48:12 +0200 Subject: [PATCH] qemu: Add missing "%s" before translation macros and break long lines. This patch cleans up some missing "%s" before translation macros, breaks long lines and some other style cleanups found while reviewing DanPB's massive cleanup for virReportError.