Re: [libvirt] [PATCH] libvirt-guests: Allow time sync on guests resume

On Wed, Feb 18, 2015 at 15:31:27 +0100, Michal Privoznik wrote: > Well, imagine domains were running, and as the host went down, they > were managesaved. Later, after some time, the host went up again and > domains got restored. But without correct time. And depending on how > long was the host shut off, it may take some time for ntp to sync the > time too. But hey, wait a minute. We have an API just for that! So: > > 1) Introduce SYNC_TIME variable in libvirt-guests.sysconf to allow > users control over the new functionality > 2) Call 'virsh domtime --sync $dom' in the libvirt-guests script. > > Unfortunately, this is all-or-nothing approach (just like anything > else with the script). Domains are required to have configured and > running qemu-ga inside. > > Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com&gt; > --- > tools/libvirt-guests.sh.in | 6 ++++++ > tools/libvirt-guests.sysconf | 7 +++++++ > 2 files changed, 13 insertions(+) > > diff --git a/tools/libvirt-guests.sh.in b/tools/libvirt-guests.sh.in > index 1b17bbe..21e39b0 100644 > --- a/tools/libvirt-guests.sh.in > +++ b/tools/libvirt-guests.sh.in > @@ -171,7 +171,9 @@ start() { > > isfirst=true > bypass= > + sync_time=false > test "x$BYPASS_CACHE" = x0 || bypass=--bypass-cache > + test "x$SYNC_TIME" = x0 || sync_time=true > while read uri list; do > configured=false > set -f > @@ -206,6 +208,10 @@ start() { > retval run_virsh "$uri" start $bypass "$name" \ > >/dev/null && \ > gettext "done"; echo > + if "$sync_time"; then > + retval run_virsh "$uri" domtime --sync "$name" \ I think 'retva' shouldn't be used here. Time sync is very prone to fail as it uses the guest agent and we should not fail to start the service for this operation that I'd consider "best effort".