Re: [libvirt] [PATCH 2/5] conf: Introduce viremulator_capabilities

On 06/24/14 21:34, Eric Blake wrote: > On 06/24/2014 03:39 AM, Daniel P. Berrange wrote: > >>> >>> We also have a <features> subelement of <guest> in the <capabilities> >>> XML which is used for a similar thing although it doesn't support a >>> per-machine-type output, only per-binary capabilities. Should we add >>> this more granular approach and abandon the old one? >> >> Yes, we should stop adding stuff related to the guest to the main >> <capabilities> XML since it doesn't scale. > > Oh phooey - I just proposed yet another feature there: > https://www.redhat.com/archives/libvir-list/2014-June/msg01097.html > > I'd like to turn on a witness for active commit support in the same > release as we turn on the qemu implementation (and I'm hoping it still > makes libvirt 1.2.6 - we haven't frozen yet, but it's near the end of > the month, and we're still waiting on some patches to make it into > qemu.git). If <features> is not the right place, then where should I > advertise it? > Well, currently in the upstream state <features> is the only place where we can do it until Michal's new API gets in. We might need to add that particular feature there if this series doesn't make it, while active commit does.