Re: [libvirt] [PATCH] qemu: Ignore libvirt debug messages in qemu log

On 03/30/2011 06:17 AM, Jiri Denemark wrote: That's rather hard-coded to our current output style; should we add comments here and to the place that outputs those lines to be careful to keep the two places in sync? Suppose you have five normal lines before the first debug line. Is it any more efficient to use use getline() to read a line at a time, and just strstr() once per line, rather than reading the entire file and having strstr() repeatedly scan multiple lines on each iteration (15 lines scanned over 5 iterations)? Or even if you don't use getline(), can you temporarily set eol to NUL so that strstr() is bounded to a given line rather than searching into the rest of the file, since the filtering is line-based? Conversely, supposed you have five debug lines followed by five normal lines. Doing the memmove() on every debug line encountered results in moving 25 lines around, whereas if you rewrite the loop to only copy one line at a time and only if it passed the filter, then you only have to move 5 lines around. I like the idea, but I think it can be made more efficient in v2. -- Eric Blake eblake(a)redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org