
Hi Jano, Thanks for your reply.
On Mon, Feb 18, 2019 at 05:21:31PM +0800, Wen Yang wrote:
From: Yi Wang <wang.yi59@zte.com.cn>
vcpupin will fail when maxvcpus is larger than current vcpu:
...
This for loop was introduced by: commit 34f77437da884f9cf0e2450f25f373b17cf527e2 qemu: fix recording of vCPU pids for MTTCG
which started recording TIDs for TCG as well. Skipping it for VIRT_QEMU reverts the benefits for multithreaded TCG, while leaving the loop broken for VIRT_KVM when not all vCPUs are enabled.
The proper fix here would be to stop considering zero TIDs as duplicate.
Ok, I will send a v2 patch. Thanks.
Jano
if (info[i].tid == vm->pid) { VIR_DEBUG("vCPU[%zu] PID %llu duplicates process", i, (unsigned long long)info[i].tid); -- 1.8.3.1
-- libvir-list mailing list libvir-list@redhat.com
--- Best wishes Yi Wang