Re: [libvirt] [PATCH 2/2] gitdm: Add gitdm configuration
On Fri, 2019-06-07 at 12:34 +0200, Ján Tomko wrote:
On Thu, Jun 06, 2019 at 04:47:59PM +0200, Andrea Bolognani wrote:
[...]
> +# This is information that's already present in .mailmap,
and having to
> +# duplicate it is annoying. Unfortunately gitdm doesn't parse .mailmap
> +# and the format is different, so we can't just point it to the file
> +# either.
Isn't the point of the files different? With .mailmap mapping multiple
addresses to one person and this file mapping it to this person's
employment?
Their purpose is only slightly different.
For .mailmap you want to ultimately end up with a single email
address associated with each physical person, so it's expected that
as the developer goes from being an unaffiliated contributor to being
employed, changes employer, and goes back to contributing in their
own time, .mailmap will be updated and consequently AUTHORS will only
reflect the current status, not the historical information. This is
okay because the generated AUTHORS is included in release tarballs,
so if you wanted to have a full view you'd only need to grab all
releases and compare them.
The gitdm configuration, on the other hand, needs to contain enough
information so that you can use it today to create reports for any
point in time in the past, which might very well involve a single
person having two or more email addresses associated with them
based on who they were working for at the time.
A perfect example of this difference is:
> +# This deviates from what's found in .mailmap, but it makes
more sense as
> +# far as gitdm is concerned since Jim was employed by Novell at the time.
> +
> +jfehlig(a)linux-ypgk.site jfehlig(a)novell.com
That said, in almost all cases these subtleties don't come into play
and the same mapping as .mailmap also applies to gitdm.
[...]
> +jim(a)meyering.net meyering(a)redhat.com
IIRC Jim no longer works at Red Hat
But he was working for Red Hat at the time he contributed to libvirt,
and he hasn't contributed since, so his contributions should show up
under "Red Hat" in the gitdm report.
[...]
> +# gitdm config for libvirt
> +# ------------------------
> +#
> +# Generate statistic for eg. v4.6.0 by running
> +#
> +# $ git log -p -M v4.5.0..v4.6.0 | gitdm
gitdm does not seem to be packaged by distros, can you link to the git
here?
Also, I had an issue with parsing logs using dates in the ISO format,
can you add --date=rfc to the example?
ACK on both counts, and I'll also fix the English mistakes you
pointed out before pushing.
Thanks for the review :)
--
Andrea Bolognani / Red Hat / Virtualization