Re: [libvirt] [PATCH] qemuDomainShutdownFlags: check for domain activeness prior to guest presence

On 05/06/2015 09:45 AM, Michal Privoznik wrote:

Running shutdown with mode agent on a shutoff domain gives cryptic error message:

virsh # shutdown --mode agent gentoo error: Failed to shutdown domain gentoo error: Guest agent is not responding: QEMU guest agent is not connected

After this patch, the error is more clear:

virsh # shutdown --mode agent gentoo error: Failed to shutdown domain gentoo error: Requested operation is not valid: domain is not running

Reported-by: Martin Kletzander <mkletzan@redhat.com> Signed-off-by: Michal Privoznik <mprivozn@redhat.com> --- src/qemu/qemu_driver.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)

ACK.