On Thu, Sep 30, 2010 at 09:23:50PM +0200, Matthias Bolte wrote:
2010/9/29 Daniel Veillard <veillard@redhat.com>:
On Wed, Aug 25, 2010 at 01:27:44PM -0300, Eduardo Otubo wrote:
When creating a new gust, the function phypBuildLpar() was not checking for NULL values, making the driver to have a segmentation fault. --- src/phyp/phyp_driver.c | 23 +++++++++++++++++++++++ 1 files changed, 23 insertions(+), 0 deletions(-)
Seems we had forgotten that old patch, applied it,
thanks !
Daniel
Ah, yes, but the patch you applied didn't fix the segfault a few lines below where def->disks[0]->src is used without checking for def->ndisks > 0 before, as I pointed out in an earlier review.
I've send an additional patch to fix this:
https://www.redhat.com/archives/libvir-list/2010-September/msg00571.html
Ahhh , please push :-) Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/