Re: [PATCH 3/8] Fixed code style bug for virBufferAddLit
On Tue, Nov 10, 2020 at 15:56:15 -0600, Ryan Gahagan wrote:
Signed-off-by: Ryan Gahagan <rgahagan(a)cs.utexas.edu>
---
tools/virsh-domain.c | 21 +++++++++++----------
1 file changed, 11 insertions(+), 10 deletions(-)
diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
index 810e55fa53..5862993464 100644
--- a/tools/virsh-domain.c
+++ b/tools/virsh-domain.c
@@ -688,7 +688,7 @@ cmdAttachDisk(vshControl *ctl, const vshCmd *cmd)
if (source || source_protocol || source_name ||
host_name || host_transport || host_socket) {
- virBufferAsprintf(&buf, "<source");
+ virBufferAddLit(&buf, "<source");
This is fixing code you've added in patch 1. Please squash all fixups
together. There's no point to commit broken code and fix it later.