Re: [libvirt] [PATCH] python: set default value to optional arguments

On 03/25/2013 04:28 PM, Martin Kletzander wrote: > On 03/25/2013 10:18 AM, Guannan Ren wrote: >> When prefixing with string (optional) or optional in the description >> of arguments to libvirt C APIs, in python, these arguments will be >> set as optional arugments, for example: >> [...] > We have a check for flags being always unsigned long, so I see no place > this could make any problems. > > ACK, > If you didn't push this yet, I suggest squashing this in as I failed to see this the first time: diff --git a/python/generator.py b/python/generator.py index 7586ffc..5adf3e0 100755 --- a/python/generator.py +++ b/python/generator.py @@ -1334,6 +1334,11 @@ def buildWrappers(module): if n != 0: classes.write(", ") classes.write("%s" % arg[0]) + if arg[0] == "flags" or is_optional_arg(arg[2]): + if is_integral_type(arg[1]): + classes.write("=0") + else: + classes.write("=None") n = n + 1 classes.write("):\n") writeDoc(module, name, args, ' ', classes) -- Thanks, Martin