On 3/15/19 8:21 AM, Eric Blake wrote:
On 3/15/19 7:46 AM, Ján Tomko wrote:
[ not sure how John Snow got on the CC list. Hi, John! ]
s/snapshot/conf/ in the summary
Sure. It's related to my work on snapshots, but independent enough (and doesn't even touch snapshot_conf).
# include "internal.h" +# include "virconftypes.h"
The files in src conf do not use the vir prefix. How about "conf_types.h"?
Naming is hard. I can live with that.
Actually, I'm leaning towards keeping the "vir" prefix (to avoid any chance of ever including a wrong file from outside of libvirt), and as you noticed we DO have other (newer) files in src/conf/ with a vir prefix. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org