On Mon, Apr 15, 2019 at 06:33:36PM +0200, Marc-André Lureau wrote:
Commit 767abe7 ("chardev: forbid 'wait' option with client sockets") is a bit too strict. Current libvirt always set wait=false, and will thus fail to add client chardev.
Make the code more permissive, allowing wait=false with client socket chardevs. Deprecate usage of 'wait' with client sockets.
Fixes: 767abe7f49e8be14d29da5db3527817b5d696a52
IOW, this is a regression in 4.0 and so desirable to fix in rc4 to avoid breaking with existing libvirt. Meanwhile libvirt should also be fixed to not pass 'wait' for client sockets.
Cc: Daniel P. Berrangé <berrange@redhat.com> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com> --- chardev/char-socket.c | 12 ++++++++---- qemu-deprecated.texi | 5 +++++ 2 files changed, 13 insertions(+), 4 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|