On 4/10/19 12:25 PM, Daniel Henrique Barboza wrote:
On 4/10/19 3:08 PM, Jim Fehlig wrote:
> I noticed libvirt-tck test domain/207-disk-media-change.t started failing
> after updating to libvirt 5.2.0. A bisection fingered commit f1d65853
>
> commit f1d6585300001c7b23b8796a0faa4411c3531996
> Author: Daniel Henrique Barboza <danielhb413(a)gmail.com>
> Date: Fri Mar 15 18:06:45 2019 -0300
>
> domain_conf: check device address before attach
>
> This commit prevents a media change on CDROM devices.
Thanks for letting us know. I'll run libvirt-tck (any pointers are appreciated -
first time I've heard about this test suite) and see if I can get a fix going.
It's easy to reproduce outside of libvirt-tck. Simply start a VM with a cdrom
device and then try to update the <source> element with 'virsh attach-device
...'. E.g. with the VM running try to "eject" the cdrom
# cat update-empty-cdrom.xml
<disk type='file' device='cdrom'>
<target dev='hdc'/>
</disk>
# virsh attach-device test update-empty-cdrom.xml
error: Failed to attach device from update-empty-cdrom.xml
error: Requested operation is not valid: Domain already contains a device with
the same address
Regards,
Jim