On 01/18/12 17:13, Eric Blake wrote:
On 01/18/2012 09:01 AM, Martin Kletzander wrote:
There was missing capability for blkiotune and thus specifying these settings caused libvirt to run qemu with invalid parameters and then reporting qemu error instead of the standard libvirt one. --- src/qemu/qemu_capabilities.c | 6 ++++++ src/qemu/qemu_capabilities.h | 2 ++ src/qemu/qemu_command.c | 13 +++++++++++++ tests/qemuxml2argvtest.c | 2 +- 4 files changed, 22 insertions(+), 1 deletions(-)
@@ -1031,6 +1033,10 @@ qemuCapsComputeCmdFlags(const char *help, qemuCapsSet(flags, QEMU_CAPS_DRIVE_AIO); if (strstr(help, "copy-on-read=on|off")) qemuCapsSet(flags, QEMU_CAPS_DRIVE_COPY_ON_READ); + if (strstr(help, "bps=") && strstr(help, "iops=") && + strstr(help, "bps_rd=") && strstr(help, "bps_wr=") && + strstr(help, "iops_rd=") && strstr(help, "iops_wr=")) + qemuCapsSet(flags, QEMU_CAPS_DRIVE_IOTUNE);
It should be sufficient to check for just one of these strings, rather than all 6, since support for all 6 should be added in the same qemu commit. Meanwhile, since qemu 1.0 does not support this feature, can you point to a commit id that will become part of qemu 1.1, and which actually confirms that this will be in the -help output?
Hi Eric, I will send it as a version 2 of the patch. I tested it against master in qemu git and just now found out the commit that enables it. Martin