On Mon, Feb 22, 2016 at 09:49:04AM -0500, Marc-André Lureau wrote:
Hi
----- Original Message -----
On 19.02.2016 15:30, Marc-André Lureau wrote:
Add Spice graphics gl attribute. qemu 2.6 should have -spice gl=on argument to enable opengl rendering context (patches on the ML). This is necessary to actually enable virgl rendering.
Add a qemuxml2argv test for virtio-gpu + spice with virgl.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com> --- docs/formatdomain.html.in | 8 ++++ docs/schemas/domaincommon.rng | 8 ++++ src/conf/domain_conf.c | 26 ++++++++++++- src/conf/domain_conf.h | 1 + src/qemu/qemu_capabilities.c | 2 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 13 +++++++ tests/qemucapabilitiesdata/caps_2.6.0-1.caps | 1 + tests/qemucapabilitiesdata/caps_2.6.0-1.replies | 4 ++ .../qemuxml2argv-video-virtio-gpu-spice-gl.args | 24 ++++++++++++ .../qemuxml2argv-video-virtio-gpu-spice-gl.xml | 38 ++++++++++++++++++ tests/qemuxml2argvtest.c | 6 +++ .../qemuxml2xmlout-video-virtio-gpu-spice-gl.xml | 45 ++++++++++++++++++++++ tests/qemuxml2xmltest.c | 1 + 14 files changed, 177 insertions(+), 1 deletion(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-video-virtio-gpu-spice-gl.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-video-virtio-gpu-spice-gl.xml create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-video-virtio-gpu-spice-gl.xml
Looking good. ACK to the design. But I'd rather postpone pushing until qemu has released the feature. Otherwise we may end up with different functionality we claim to be supported than qemu does. Yet again.
How much of a problem is this, since there are caps checks? (assuming the interface in qemu doesn't change - I don't think it will).
We were aiming for fedora 24 if possible, but I see qemu 2.6 is planned for 04-26, which is a week after Fedora code complete deadline 04-19. It's a bit sad to delay by >2 months given that Spice support is now finally ready. Many people are eager to have accelerated VMs in virt-manager, I wonder what solution we can find to shorten the delay.
We don't have to wait until QEMU 2.6 is released IMHO. QEMU hard feature freeze is March 29th http://wiki.qemu.org/Planning/2.6 If we wait until that point, we can be confident enough the QEMU interface won't be changing before 2.6 GA, and still haved time to get a libvirt release with this stuff included and into Fedora 24. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|