On Tue, Apr 24, 2018 at 02:17:00PM +0200, Michal Privoznik wrote:
On 04/19/2018 07:09 PM, Daniel P. Berrangé wrote:
We previously added "-z nodelete" to the build of libvirt.so to prevent crashes when thread local destructors run which point to a code that has been dlclose()d:
commit 384b9a76a5e387f64cfe8f83f4a518bb302e80f7 Author: Daniel P. Berrangé <berrange@redhat.com> Date: Thu Apr 19 11:42:22 2018 +0100
driver: prevent unloading of dlopen'd modules
This commit does not exist. However 8e44e5593eb does.
Yes, yes, copied in a local commit by mistake - the hash you mention is indeed the right one.
We forgot to copy this protection into the libvirt-qemu.so, libvirt-lxc.so and libvirt-admin.so libraries when we introduced them.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> --- src/Makefile.am | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
ACK
Michal
Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|