Re: [libvirt] [PATCH v2 0/2] qemu: cpu: fix "full" CPU to include all "reported" CPU features

On 18.04.2018 12:11, Jiri Denemark wrote: > On Wed, Apr 11, 2018 at 11:57:30 +0300, Nikolay Shirokovskiy wrote: >> diff from v1: >> - add test data for CPU for which issue was triggered >> >> Patch 1 adds tests for CPU on which problem was detected. However we >> don't test <cpu mode='host-model' check='partial'> case which have >> issue. >> >> Patch 2 is actual fix. >> >> Nikolay Shirokovskiy (2): >> cputest: New test for Intel Core i5-650 >> qemu: cpu: fix "full" CPU to include all "reported" CPU features > > Oh I see. Thanks for the CPU data which helped me understand what > problem you are fixing. The patch is indeed correct, but I can't push it > since it is missing the Signed-off-by line. You can either resubmit the > patches with SoB line added or just reply with the SoB line here and > I'll update the patches before pushing. > > Series > > Reviewed-by: Jiri Denemark <jdenemar(a)redhat.com&gt; > Ahhh, keep forgetting SoB. Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy(a)virtuozzo.com&gt;