Re: [PATCH V2 9/9] kbase: Update rpm-deployment.rst with new subpackages
On 12/14/22 11:08, Andrea Bolognani wrote:
On Tue, Dec 13, 2022 at 05:31:02PM -0700, Jim Fehlig wrote:
> Signed-off-by: Jim Fehlig <jfehlig(a)suse.com>
> ---
> docs/kbase/rpm-deployment.rst | 38 ++++++++++++++++++++++++++++-------
> 1 file changed, 31 insertions(+), 7 deletions(-)
>
> diff --git a/docs/kbase/rpm-deployment.rst b/docs/kbase/rpm-deployment.rst
> index b5ee7fd827..bf2f4f5a6b 100644
> --- a/docs/kbase/rpm-deployment.rst
> +++ b/docs/kbase/rpm-deployment.rst
> @@ -42,14 +42,17 @@ RPM packages
> stateful drivers. This package does not contain any drivers, so further
> packages need to be installed to provide the desired drivers.
>
> - In addition to the libvirtd daemon this package also contains the virtlogd,
> - virtlockd and virtproxyd daemons, plus a number of helpers, configuration
> - files and other bits necessary to create and admin a virtualization host.
> + This package depends on libvirt-daemon-common, libvirt-daemon-lock,
> + libvirt-daemon-plugin-lockd, libvirt-daemon-log, and libvirt-daemon-proxy.
We probably want to point out that this package should *not* be
installed for new deployments.
Looking at the page in its entirety, I think it would make sense to
have the "Deployment choices" section first and the "RPM packages"
section after it. That is, provide the quick recipes upfront, and
leave the finer details for those who are interested in them.
Agreed, but it is unrelated to this work. Can it be a separate task?
> +* libvirt-daemon-common
> + This package contains liibvirt-guests, virt-host-validate, virt-ssh-helper
*libvirt-guests
> +* libvirt-daemon-plugin-lockd
> + This package provides the lockd.so module, a daemon plugin for communicating
> + with a virtlockd configured to use POSIX fcntl advisory locks.
> +
> +* libvirt-daemon-plugin-sanlock
> + This package provides the sanlock.so module, a daemon plugin for communicating
> + with a virtlockd configured to use sanlock.
Based on Dan's explanation, these descriptions are not accurate: the
lockd.so module is used by the hypervisor driver to manage locks via
virtlockd, while the sanlock.so to do the same via sanlock.
I think the first one is accurate. lockd.so is a plugin for daemons to
communicate with virtlockd. Daniel wrote
"virtqemud locks(sic) the lockd.so plugin, as lockd.so
provides the client impl to talk to virtlockd. Think of lockd.so
as being equiv of libvirt.so".
I assume sanlock.so is the same. It provides the client impl for daemons to talk
to virtlockd's sanlock backend. Regardless, suggestions on the actual text to
put here would be much appreciated.
Regards,
Jim