Re: [libvirt] [PATCH v4 05/31] util: command: remove redundant include directive
On Fri, Jul 13, 2018 at 11:24:43PM +0530, Sukrit Bhatnagar wrote:
viralloc.h is pulled in by vircommand.h
Signed-off-by: Sukrit Bhatnagar <skrtbhtngr(a)gmail.com>
Reviewed-by: Erik Skultety <eskultet(a)redhat.com>
---
src/util/vircommand.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/util/vircommand.c b/src/util/vircommand.c
index 6dab105..8681e7b 100644
--- a/src/util/vircommand.c
+++ b/src/util/vircommand.c
@@ -44,7 +44,6 @@
#define __VIR_COMMAND_PRIV_H_ALLOW__
#include "vircommandpriv.h"
-#include "viralloc.h"
#include "virerror.h"
#include "virutil.h"
#include "virlog.h"
Hmm, it actually would have been better if this was squashed into the previous
patch where you're adding the define. The same applies to patches 9,13,15,19,23.
I'll squash them before pushing.
Erik