Re: [libvirt] [PATCH v2 1/2] tests: add targets for building libvirt inside docker containers

On Fri, 2019-03-15 at 15:06 +0000, Daniel P. Berrangé wrote: > > > + @echo "Available targets:" > > > + @echo > > > + @echo " cibuild-\$$IMAGE - run a default 'make'" > > > + @echo " cicheck-\$$IMAGE - run a 'make check'" > > > + @echo " cishell-\$$IMAGE - run an interactive shell" > > > > Just a thought: instead of > > > > make ci-build-centos-7 MAKE_ARGS=check > > > > and in the future > > > > make ci-build-debian-9-cross-aarch64 > > > > would it make sense to have something like > > > > make ci-build OS=centos-7 MAKE_ARGS=check > > make ci-build OS=debian-9 CROSS=aarch64 > > > > instead? A bit more typing, perhaps, but it looks kinda better > > in my opinion, with the variable parts clearly presented as such... > > I rather prefer the more concise target names - I don't think it > really adds anything to use variables I disagree on concise: they're definitely shorter, but that's because all the information is squished together, which makes it harder to parse at a glance. When naming Docker images we don't have much of a choice, because we have pretty much the same restrictions as when naming files, but that's not the case here so we could do better...