Re: [libvirt] [PATCH 05/10] conf: Introduce new attribute for device address format
On 2012年02月18日 01:03, Paolo Bonzini wrote:
On 02/17/2012 05:54 PM, Osier Yang wrote:
>> Yeah, I definitely misunderstood. Here it is correct to print the
>> target for all models.
>
> Do you mean it's correct check the model here? I think the "lsilogic"
> model won't want to see the "target". It's complete useless.
It's true that it's useless. However, there is no reason not to print
it; so is "bus", for example. Also, even for non-SCSI disks you need
to print the target. You may omit it if it is zero, but I'm not sure
it brings any benefit to do so.
Finally I understand you, yeah, it's no harm to print the target. Except
we need another patch to change lots of the tests.
By the way, you need to test for "target == 0" and print an error also
when creating an IDE or AHCI disk.
Agreed.
Paolo