Re: [libvirt] [PATCH 10/12] qemu: blockstats: Refactor qemuDomainBlockStatsFlags
On Tue, Mar 10, 2015 at 05:26:39PM +0100, Peter Krempa wrote:
Now that qemuDomainBlocksStatsGather provides functions of both
qemuMonitorGetBlockStatsParamsNumber and qemuMonitorGetBlockStatsInfo we
can reuse it and kill a lot of code.
Additionally as a bonus qemuDomainBlockStatsFlags will now support
summary statistics so add a statement to the virsh man page about that.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1142636
man
What manual page do you want?
---
src/qemu/qemu_driver.c | 82 +++++++++++---------------------------------------
tools/virsh.pod | 5 +--
2 files changed, 21 insertions(+), 66 deletions(-)
@@ -10748,13 +10703,12 @@ qemuDomainBlockStatsFlags(virDomainPtr dom,
/* Field 'errs' is meaningless for QEMU, won't set it. */
Do we need this comment?
ret = 0;
- *nparams = tmp;
+ *nparams = nstats;
endjob:
qemuDomainObjEndJob(driver, vm);
cleanup:
- VIR_FREE(diskAlias);
VIR_FREE(blockstats);
qemuDomObjEndAPI(&vm);
return ret;
}
ACK with the leak fixed.
Jan
Attachments:
- signature.asc (application/pgp-signature — 819 bytes)